Skip to content

Handle sanitization of security, marginwidth & marginheight iframe attributes#3954

Merged
westonruter merged 1 commit intodevelopfrom
fix/3950-sanitize-iframe-attrs
Dec 18, 2019
Merged

Handle sanitization of security, marginwidth & marginheight iframe attributes#3954
westonruter merged 1 commit intodevelopfrom
fix/3950-sanitize-iframe-attrs

Conversation

@pierlon
Copy link
Copy Markdown
Contributor

@pierlon pierlon commented Dec 17, 2019

Summary

When sanitizing iframes:

  • Remove the obsolete security attribute
  • Remove the obsolete marginwidth and marginheight attributes if their values are 0.

Fixes #3950.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label Dec 17, 2019
@pierlon pierlon requested a review from westonruter December 17, 2019 23:38
@pierlon pierlon force-pushed the fix/3950-sanitize-iframe-attrs branch from b8c4d7b to 5b82aac Compare December 17, 2019 23:39
@pierlon
Copy link
Copy Markdown
Contributor Author

pierlon commented Dec 17, 2019

Rebased to remove file not pertaining to this PR.

@westonruter westonruter added this to the v1.5 milestone Dec 18, 2019
@pierlon pierlon force-pushed the fix/3950-sanitize-iframe-attrs branch from 567a095 to 11f9b7a Compare December 18, 2019 07:06
@pierlon
Copy link
Copy Markdown
Contributor Author

pierlon commented Dec 18, 2019

⚠️ Rebasing with latest changes from develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Omit security=restricted and handle marginheight/marginwidth attributes in iframe sanitizer

3 participants