Ensure Stories preview in e2e tests meets minimum viewport requirements.#3797
Merged
westonruter merged 1 commit intodevelopfrom Nov 20, 2019
Merged
Ensure Stories preview in e2e tests meets minimum viewport requirements.#3797westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the e2e tests interactively, there was a consistent failure of the
amp-storypreview page which seems to be causing an issue with the testing suite.In short, when AMP detects that the screen is of a specific larger size, it uses the desktop version of Stories, which requires a minimum width of 1024px and height of 550px. When this viewport requirement is not met, AMP displays an notice to the user to adjust the size of the viewport, which may have been causing those errors.
This pull request sets the Stories preview to the minimum AMP requirements (for desktop).