Add AMP_DOM_Document & meta tag sanitizer#3758
Merged
westonruter merged 67 commits intodevelopfrom Dec 19, 2019
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an abstraction for the DOM document and a new sanitizer
AMP_Meta_Sanitizerthat sanitizes meta tags in general, but more specifically for now the charset tag.Dom\Documentto abstract away charset and document structure requirements.Dom\Document::from_html()to construct from markup (and deprecateAMP_DOM_Utils::get_dom()).Dom\Document::from_node()to construct from a node (and deprecateAMP_DOM_Utils::get_dom_from_content_node()).<head>and<body>elements.<meta charset="<charset>">format.utf-8is not met.AMP_DOM_Utilsto internalDom\Documentmethods and deprecate accordingly.Fixes #3469
Fixes #855
Checklist