Prevent closing a modal when clicking on a contained input#3663
Merged
westonruter merged 2 commits intodevelopfrom Oct 29, 2019
Merged
Prevent closing a modal when clicking on a contained input#3663westonruter merged 2 commits intodevelopfrom
westonruter merged 2 commits intodevelopfrom
Conversation
westonruter
approved these changes
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an action to a modal's
.modal-innerelement to immediately revert amodal.closeaction again.This allows us to have the modal serve as a background that closes itself when clicking on and avoids the modal immediately closing again when clicking on an actual input within the modal.
This is a work-around as suggested in https://stackoverflow.com/a/45971501.
Fixes #3342
Checklist