Skip to content

If text has been pasted, also force update dimesisions.#3644

Merged
miina merged 2 commits intodevelopfrom
fix/paste-text
Oct 28, 2019
Merged

If text has been pasted, also force update dimesisions.#3644
miina merged 2 commits intodevelopfrom
fix/paste-text

Conversation

@spacedmonkey
Copy link
Copy Markdown
Contributor

Summary

Fixes #3291

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

Looks like tests are failing, the same tests have failed previously as well, looks like these tests need looking into: https://travis-ci.org/ampproject/amp-wp/jobs/603942453#L922-L962 (EDIT: Rerunning overwrote it, so this link is incorrect, however, some of the resizing tests are sometimes failing, will log it properly the next time).

Rerunning the tests since these are unrelated to this PR.

@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

Hmm, I'm still seeing the issue:
issue

Could you confirm that you see it fixed?

@spacedmonkey
Copy link
Copy Markdown
Contributor Author

@miina that is copying text into an existing text block. That is not the issue, all through that would be another issue. Look at the testing instructions.

Here is a video of it working for me - https://youtu.be/X8i0Tb71QLc

@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

Thanks for the clarification, somehow assumed that this would cover all the pasting issues! Will create a separate issue for pasting into an existing block then.

Copy link
Copy Markdown
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

Would you mind merging develop too?

@spacedmonkey
Copy link
Copy Markdown
Contributor Author

Would you mind merging develop too?

Go for it.

@spacedmonkey spacedmonkey added this to the v1.4 milestone Oct 28, 2019
@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Oct 28, 2019
@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

@googlebot I consent.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Oct 28, 2019
@spacedmonkey
Copy link
Copy Markdown
Contributor Author

I don't have access to merge PRs even if they are approved.

@miina
Copy link
Copy Markdown
Contributor

miina commented Oct 28, 2019

I was asking if you would mind merging develop into this PR :) (Since you said "go for it", did it myself already, waiting for Travis now)

@miina miina merged commit f5e7897 into develop Oct 28, 2019
@miina miina deleted the fix/paste-text branch October 28, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text block does not update height after pasting

4 participants