If text has been pasted, also force update dimesisions.#3644
Conversation
|
Looks like tests are failing, the same tests have failed previously as well, looks like these tests need looking into: https://travis-ci.org/ampproject/amp-wp/jobs/603942453#L922-L962 (EDIT: Rerunning overwrote it, so this link is incorrect, however, some of the resizing tests are sometimes failing, will log it properly the next time). Rerunning the tests since these are unrelated to this PR. |
|
@miina that is copying text into an existing text block. That is not the issue, all through that would be another issue. Look at the testing instructions. Here is a video of it working for me - https://youtu.be/X8i0Tb71QLc |
|
Thanks for the clarification, somehow assumed that this would cover all the pasting issues! Will create a separate issue for pasting into an existing block then. |
|
Would you mind merging |
Go for it. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
I don't have access to merge PRs even if they are approved. |
|
I was asking if you would mind merging |

Summary
Fixes #3291
Checklist