Merged
Conversation
miina
reviewed
Oct 16, 2019
assets/src/stories-editor/components/higher-order/with-amp-story-settings.js
Show resolved
Hide resolved
Contributor
|
Hmm, there are still some oddities happening but it looks like something that was happening pre-3447 and pre-3433 --- at least looks like that when checking out a commit before those.
Perhaps related to |
miina
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses a regression, that was assumed to come from #3447, but actually arose from #3433.
hasTextContentmust be set to true by default for all meta text blocks.Suggestions for a better/cleaner
isMetaTextBlockare very welcome as are references to a similar "calculation" elsewhere.Fixes #3447
Checklist