Skip to content

Remove sidebar button#3535

Merged
swissspidy merged 6 commits intodevelopfrom
feature/remove-sidebar-button
Oct 16, 2019
Merged

Remove sidebar button#3535
swissspidy merged 6 commits intodevelopfrom
feature/remove-sidebar-button

Conversation

@spacedmonkey
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey commented Oct 15, 2019

Summary

Add remove page button to sidebar.

Fixes #3279

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@spacedmonkey spacedmonkey requested a review from barklund October 15, 2019 19:00
@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 15, 2019
@spacedmonkey
Copy link
Copy Markdown
Contributor Author

Not sure what I should do in terms of testing for this one.

@spacedmonkey spacedmonkey marked this pull request as ready for review October 16, 2019 10:25
spacedmonkey and others added 2 commits October 16, 2019 13:08
Co-Authored-By: Pascal Birchler <pascalb@google.com>
Co-Authored-By: Pascal Birchler <pascalb@google.com>
Copy link
Copy Markdown
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swissspidy swissspidy added this to the v1.3.1 milestone Oct 16, 2019
@swissspidy swissspidy merged commit 9fa1b53 into develop Oct 16, 2019
@swissspidy swissspidy deleted the feature/remove-sidebar-button branch October 16, 2019 14:27
@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple way to remove AMP story pages

4 participants