Set layout to responsive if the iframe is aligned to full width#3507
Merged
westonruter merged 2 commits intodevelopfrom Oct 16, 2019
Merged
Set layout to responsive if the iframe is aligned to full width#3507westonruter merged 2 commits intodevelopfrom
westonruter merged 2 commits intodevelopfrom
Conversation
westonruter
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an iframe is set to be "full width" in the block editor, it is currently broken because its
layoutattribute defaults to'intrinsic'.This PR changes this behavior so that such an iframe is set to
layout=responsiveinstead.Fixes #3506
Screenshots
Comparison after the change:
Markup after the change:
Checklist