Skip to content

Fix dropzone by adding key#3485

Merged
miina merged 1 commit intodevelopfrom
fix/3454-bad-dropzone
Oct 11, 2019
Merged

Fix dropzone by adding key#3485
miina merged 1 commit intodevelopfrom
fix/3454-bad-dropzone

Conversation

@miina
Copy link
Copy Markdown
Contributor

@miina miina commented Oct 11, 2019

Summary

Fixes #3455

Props @barklund

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Has not signed the Google CLA label Oct 11, 2019
@miina miina requested a review from spacedmonkey October 11, 2019 11:08
Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested locally and works as expected.

@swissspidy
Copy link
Copy Markdown
Collaborator

@miina #3454 is a PR, but which issue does this fix? :-)

Also, is this the right place to put the key? See https://reactjs.org/docs/lists-and-keys.html#extracting-components-with-keys

@swissspidy
Copy link
Copy Markdown
Collaborator

Looks like @barklund needs to ping the bot, as its his commit 🙂

@spacedmonkey
Copy link
Copy Markdown
Contributor

@miina #3454 is a PR, but which issue does this fix? :-)

I have updated the PR to reference #3455

@miina
Copy link
Copy Markdown
Contributor Author

miina commented Oct 11, 2019

@swissspidy See this comment about adding the key (and the rest of the thread for context if you have time 😄 ).

@barklund
Copy link
Copy Markdown
Contributor

@googlebot I consent.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Oct 11, 2019
@miina miina merged commit d10b455 into develop Oct 11, 2019
@miina miina deleted the fix/3454-bad-dropzone branch October 11, 2019 13:24
@swissspidy swissspidy added this to the v1.3.1 milestone Oct 11, 2019
@swissspidy swissspidy modified the milestones: v1.3.1, v1.4 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dragging only possible after selecting page first

5 participants