Skip to content

Reduce keyboard cut handler to equal a copy handler to avoid bugs#3241

Merged
westonruter merged 2 commits intodevelopfrom
fix/2989-revert-to-least-critical-bug
Sep 13, 2019
Merged

Reduce keyboard cut handler to equal a copy handler to avoid bugs#3241
westonruter merged 2 commits intodevelopfrom
fix/2989-revert-to-least-critical-bug

Conversation

@barklund
Copy link
Copy Markdown
Contributor

Fixes #2989.

With this change, using the keyboard to cut a block, nothing visually happens, but the selected block is actually copied. Users can still right-click cut the block if they want.

This must be fixed in a future ticket. See inline todo for a description of the issue.

…id bugs

Fixes #2989.

With this change, using the keyboard to cut a block, nothing visually happens, but the selected block is actually copied. Users can still right-click cut the block if they want.

This must be fixed in a future ticket. See inline `todo` for a description of the issue.
@barklund barklund added Bug Something isn't working AMP Stories labels Sep 13, 2019
@barklund barklund added this to the v1.3 milestone Sep 13, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 13, 2019
Copy link
Copy Markdown
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonruter westonruter merged commit da5c94a into develop Sep 13, 2019
@westonruter westonruter deleted the fix/2989-revert-to-least-critical-bug branch September 13, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Right-Click: Add options to cut/copy/paste blocks

4 participants