Fix custom CTA text for page attachment#3237
Merged
westonruter merged 3 commits intodevelopfrom Sep 13, 2019
Merged
Conversation
Fixes #1973. FE saves the CTA text in a variable named `openText`, but the backend used `text` to access it. With a simple rename it works as expected with and without CTA text specified.
Contributor
|
@barklund Just wondering about the failing e2e tests. Have you looked into the test run and verified the issues are not related to this change? |
…cta-property-name * 'develop' of github.com:ampproject/amp-wp: Remove extra line I added in resolving merge conflict Fix cut handler by shortcut Cleanup of duplicated comment Add unit testing to `addVideoAriaLabel` Remove unused piece of code Add skipped e2e test for the video block Add @link tags for the code that the classes were copied from Remove extra @param tag for alternateMinImageDimensions Update assets/src/common/helpers/index.js Slightly update wording Add accessibility label for video blocks Add an e2e test for featured image notices in the block editor Remove another reference to cropping, that doesn't apply to this class Remove a DocBlock description that applies to another class Remove cropping from the non-AMP Story editor (posts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1973.
FE saves the CTA text in a variable named
openText, but the backend usedtextto access it. With a simple rename it works as expected with and without CTA text specified.