Add warning notice to AMP settings screen when not using HTTPS#3219
Merged
westonruter merged 3 commits intodevelopfrom Sep 11, 2019
Merged
Add warning notice to AMP settings screen when not using HTTPS#3219westonruter merged 3 commits intodevelopfrom
westonruter merged 3 commits intodevelopfrom
Conversation
Collaborator
Author
|
While writing this PR I noticed that there is some escaping missing in this class and opened a new issue for this: #3217 |
swissspidy
reviewed
Sep 10, 2019
swissspidy
reviewed
Sep 10, 2019
westonruter
approved these changes
Sep 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a notice to the AMP Settings screen to warn users when their site is not being served over HTTPS.
To check this, it doesn't solely rely on
is_ssl()but also checks theurlandwpurloptions, similar to what Site Health does, to make sure we get a value for the frontend as well.The warning links to the official HTTPS support page from WP: https://wordpress.org/support/article/why-should-i-use-https/
Fixes #2006