Skip to content

Remove now obsolete withEnforcedVideoUploadType HOC#3189

Merged
swissspidy merged 1 commit intodevelopfrom
remove/withEnforcedVideoUploadType
Sep 6, 2019
Merged

Remove now obsolete withEnforcedVideoUploadType HOC#3189
swissspidy merged 1 commit intodevelopfrom
remove/withEnforcedVideoUploadType

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

Since we added our custom video block edit component (assets/src/stories-editor/components/custom-video-block-edit.js), we don't need withEnforcedVideoUploadType anymore to override the accept prop

@swissspidy swissspidy added AMP Stories Needs Testing Issues that need to be confirmed. labels Sep 5, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Sep 5, 2019
@swissspidy swissspidy added this to the v1.3 milestone Sep 5, 2019
@kienstra
Copy link
Copy Markdown
Contributor

kienstra commented Sep 6, 2019

Hi @swissspidy,
Nice, it's good to see the codebase simplified 😄

If it's alright, I might not review this until Monday, as I'm on planned time off.

Have a great rest of the week.

Copy link
Copy Markdown
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I search the code base for other references and found nothing. Nothing that I would find. Unit and e2e tests in travis.

@swissspidy swissspidy merged commit be9a49d into develop Sep 6, 2019
@swissspidy swissspidy deleted the remove/withEnforcedVideoUploadType branch September 6, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA Needs Testing Issues that need to be confirmed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants