Fix encoding error when HTML5 meta charset does not appear at beginning of head#2970
Merged
westonruter merged 1 commit intodevelopfrom Aug 5, 2019
Merged
Fix encoding error when HTML5 meta charset does not appear at beginning of head#2970westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://wordpress.org/support/topic/big-problem-in-my-persian-site/
It turns out that libxml>=2.6 fails to read the
<meta charset=…>if it is not the first child of thehead. So this PR adds the old-school HTML4<meta http-equiv=Content-Type>tag which was required always prior to libxml 2.6 so that it will be added unconditionally.Build for testing: amp.zip - v1.2.1-beta1-20190805T220646Z-680afba9