Merged
Conversation
Adds subfolders to `tests/` and updates the e2e config with to bring it in line with what has been added to core.
Otherwise AMP plugin activation bails
Collaborator
Author
|
@westonruter @kienstra Let me know if anything about this proposed test setup is unclear or not working as intended. It should be a simple to run |
swissspidy
commented
Jul 1, 2019
Contributor
|
Approved Hi @swissspidy,
There are just some minor comments below. |
kienstra
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new local environment based on Docker that can be used for developing the plugin, but most importantly for running e2e tests using Puppeteer.
This has been made possible by the fine folks working on Gutenberg and WordPress core who spearheaded work on a common infrastructure.
Some nice side effects of this new setup is the addition of scripts like
./bin/local-env/install-composer.shand./bin/local-env/install-node-nvm.shto verify the base requirements for developing this plugin are installed.Documentation about this new setup and local development in general can be found in
contributing.md.Tests for the following areas are included so far:
No tests have been written yet for the editor parts of the plugin. However, especially for AMP Stories the latest version of Gutenberg is always installed so that this is easily possible in the future.
Fixes #2696.
Fixes #1823.