Account for escaped chars in CSS class names#2260
Merged
westonruter merged 1 commit intodevelopfrom May 7, 2019
Merged
Conversation
Member
Author
|
Note that the use of regular expressions should give way to using an actual CSS selector parser in #2102. |
03cf8d1 to
18b9dc3
Compare
Member
Author
|
Fix confirmed: #2259 (comment) |
swissspidy
approved these changes
May 7, 2019
Member
Author
|
Cherry-picked onto 1.1 branch: f643c21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS class names normally just contain alphanumeric characters, in addition to hyphens and underscores. However, they can include other characters as long as they are escaped with a backslash. This PR fixes the tree shaker class name extraction to account for escaped characters.
Fixes #2259.
Build for testing: amp.zip (v1.1.2-alpha-20190506T022223Z-2b70b363)