Skip to content

Remove intl from required extensions; add add date/spl as required; add others to suggest#2190

Merged
westonruter merged 2 commits intodevelopfrom
update/intl-dependency-requirement
Apr 25, 2019
Merged

Remove intl from required extensions; add add date/spl as required; add others to suggest#2190
westonruter merged 2 commits intodevelopfrom
update/intl-dependency-requirement

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Apr 24, 2019

It turns out that intl isn't actually a requirement. I tried deploying changes merged in #2183 to Pantheon and upon doing so the plugin stopped initializing due to the intl extension not being installed. In fact, the extension is not required as we do a function_exists check before using it:

amp-wp/includes/class-amp-http.php

Lines 205 to 209 in 98c2545

if ( function_exists( 'idn_to_utf8' ) ) {
// The third parameter is set explicitly to prevent issues with newer PHP versions compiled with an old ICU version.
// phpcs:ignore PHPCompatibility.Constants.RemovedConstants.intl_idna_variant_2003Deprecated
$domain = idn_to_utf8( $domain, IDNA_DEFAULT, defined( 'INTL_IDNA_VARIANT_UTS46' ) ? INTL_IDNA_VARIANT_UTS46 : INTL_IDNA_VARIANT_2003 );
}

@westonruter westonruter added this to the v1.1.2 milestone Apr 24, 2019
@westonruter westonruter requested a review from swissspidy April 24, 2019 23:36
@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 24, 2019
@swissspidy
Copy link
Copy Markdown
Collaborator

swissspidy commented Apr 25, 2019

Can we add a suggest entry for intl in that case?

@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Apr 25, 2019

Is there anything that is not considered in the composer.json?! See c57348a.

@westonruter westonruter merged commit 6478d69 into develop Apr 25, 2019
@westonruter westonruter changed the title Remove intl from required extensions Remove intl from required extensions; add add date/spl as required; add others to suggest Apr 25, 2019
@swissspidy swissspidy deleted the update/intl-dependency-requirement branch April 25, 2019 16:37
@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Apr 25, 2019

Cherry-picked onto 1.1 branch: ae6d1bd & d79d1f3

@westonruter westonruter mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@westonruter @swissspidy @googlebot