Allow AMP Stories to work in Reader mode#2143
Merged
westonruter merged 2 commits intoamp-stories-reduxfrom Apr 17, 2019
Merged
Conversation
Member
|
Yes! This is super necessary. |
Member
Author
|
Note: One side effect of the changes here (specifically 4645a4a) is that making changes to non-story posts when in Reader mode will start to show the validation error messages. Previously the validation warnings would only be shown when in Native/Transitional mode. The validation notices will likely be a source of complaints for users when in Reader mode, since they would be reported as if the Transitional mode is active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2137.