[AMP Stories] Re-render components when switching back from code editor#2117
Merged
swissspidy merged 4 commits intoamp-stories-reduxfrom Apr 29, 2019
Merged
[AMP Stories] Re-render components when switching back from code editor#2117swissspidy merged 4 commits intoamp-stories-reduxfrom
swissspidy merged 4 commits intoamp-stories-reduxfrom
Conversation
Collaborator
Author
|
Ugh. Looks like a |
Contributor
|
Approved Hi @swissspidy, Maybe this would be pending the
|
kienstra
approved these changes
Apr 12, 2019
Member
|
This is a very welcome change. I was noticing the UI getting blown away when switching to the code editor and back as well. @swissspidy Let us know when you've addressed the other issue you noted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on the default templates I was annoyed that the visual editor was kinda broken when switching back from the code editor.
The reason is that many of the custom DOM nodes get lost in that process.
This PR re-renders the components when switching back and forth between the two modes. It's admittedly a bit hacky, because it needs to wait for the editor to finish render first. I haven't found a better solution yet.