Prevent adding noscript fallbacks for AMP components inside AMP Stories#2107
Merged
westonruter merged 4 commits intoamp-stories-reduxfrom Apr 11, 2019
Merged
Conversation
swissspidy
approved these changes
Apr 11, 2019
Collaborator
swissspidy
left a comment
There was a problem hiding this comment.
Code looks good and the fix works as described 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
add_noscript_fallbackargument to the sanitizers forimg,video,audio, andiframe. By default thisadd_noscript_fallbackistrue, but for AMP Stories it gets set tofalse.Builds on #1861 and #1913.
It turns out that the
amp-img > noscript > imgandamp-video > noscript > video(and others perhaps) are not allowed in AMP Stories. Tnoscript > imgfallback foramp-img.noscript > videofallback foramp-videonoscriptfallbacks are needed for other elements (e.g.amp-audio)[RESOLVED] Outstanding Issue: Adding a video block
Adding a video block is causing a validation error: