Skip to content

Use version 2.0 of WPCS#1868

Merged
westonruter merged 3 commits intodevelopfrom
wpcs-2.0
Feb 18, 2019
Merged

Use version 2.0 of WPCS#1868
westonruter merged 3 commits intodevelopfrom
wpcs-2.0

Conversation

@swissspidy
Copy link
Copy Markdown
Collaborator

@swissspidy swissspidy commented Feb 18, 2019

Version 2.0 of https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards was released in January with lots of improvements and, naturally, some breaking changes.

This PR does:

  • Update WPCS to version 2.0.0
  • Rename all phpcs:ignore comments to reflect upstream name changes
  • Update PHPCS config after support for comma-separated property lists was removed in 2.0 (after being deprecated in 1.0)
  • Renames private property in AMP_Autoloader to prevent PHPCS warnings

Supersedes #1814.
Fixes #1859.

@googlebot googlebot added the cla: yes Signed the Google CLA label Feb 18, 2019
@swissspidy swissspidy mentioned this pull request Feb 18, 2019
Closed
1 task
@westonruter
Copy link
Copy Markdown
Member

westonruter commented Feb 18, 2019

Three remaining phpcs issues it seems:

includes/class-amp-theme-support.php:857:48: error - The constant "PHP_INT_MIN" is not present in PHP version 5.6 or earlier (PHPCompatibility.Constants.NewConstants.php_int_minFound)
tests/stubs.php:11:1: warning - Only one object structure is allowed in a file (Generic.Files.OneObjectStructurePerFile.MultipleFound)
tests/test-class-amp-theme-support.php:1845:1: warning - Only one object structure is allowed in a file (Generic.Files.OneObjectStructurePerFile.MultipleFound)

@westonruter westonruter added this to the v1.1 milestone Feb 18, 2019
@westonruter westonruter merged commit 0f74bdb into develop Feb 18, 2019
@westonruter westonruter deleted the wpcs-2.0 branch February 18, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter approved these changes

Assignees

No one assigned

Labels

cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@swissspidy @westonruter @googlebot