Skip to content

Improve validation of children#1860

Merged
westonruter merged 17 commits intodevelopfrom
improve/children-validation
Feb 11, 2019
Merged

Improve validation of children#1860
westonruter merged 17 commits intodevelopfrom
improve/children-validation

Conversation

@westonruter
Copy link
Copy Markdown
Member

This cherry-picks the commits by @miina from #1614 that relate specifically to the AMP spec and whitelist sanitizer. The intention here is that we can get this code merged into develop sooner for overall improvement to the plugin's AMP validation system, and leave the amp-stories branch purely for the UI for AMP stories.

@westonruter westonruter added this to the v1.1 milestone Feb 8, 2019
@googlebot googlebot added the cla: no Has not signed the Google CLA label Feb 8, 2019
@westonruter westonruter added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Feb 8, 2019
@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Feb 8, 2019
@westonruter westonruter added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Feb 8, 2019
…iling tests which show areas needing attention
@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Feb 8, 2019
@ampproject ampproject deleted a comment from googlebot Feb 8, 2019
@ampproject ampproject deleted a comment from googlebot Feb 8, 2019
@ampproject ampproject deleted a comment from googlebot Feb 8, 2019
@ampproject ampproject deleted a comment from googlebot Feb 8, 2019
@westonruter
Copy link
Copy Markdown
Member Author

(Apparently the CLA bot doesn't like cherry-picked commits!)

"reference": "tags/1811091519050"
}
}
},
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz Any suggestion for a better way to do this?

@westonruter
Copy link
Copy Markdown
Member Author

@miina How's this look now? If you can give it a ✅ approval that would be great.

Copy link
Copy Markdown
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@westonruter westonruter added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Feb 11, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants