AMP Mode Notice for Index listings#1376
Merged
westonruter merged 4 commits intodevelopfrom Sep 5, 2018
Merged
Conversation
kienstra
previously requested changes
Sep 4, 2018
Contributor
There was a problem hiding this comment.
Looks Good, A Few Points
Hi @miina,
Thanks for your thorough work, including describing the notices in detail.
There are a few suggestions here.
westonruter
reviewed
Sep 5, 2018
westonruter
approved these changes
Sep 5, 2018
b34e7f4 to
30213e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1366.
Adds admin notice to
Invalid PagesandValidation Errorsindex listings according to the AMP Mode and configuration.The notices:
The site is using native AMP mode, the validation errors found are already automatically handled.The site is using paired AMP mode with auto-sanitization turned on, the validation errors found are already automatically handled.The site is using paired AMP mode without auto-sanitization, the validation errors found require action and influence which pages are shown in AMP. For automatically handling the errors turn on auto-sanitization from Validation Handling settings. (<--- link)The site is using classic AMP mode, your theme templates are not used and the errors below are irrelevant.<--- Although the index pages are not visible when in classic mode, it is possible to see this notice when turning on Classic mode in one tab and refreshing an index page in the other tab, thus the notice.