Output admin notice if persistent object caching is not present#1050
Merged
westonruter merged 3 commits intoampproject:developfrom Apr 3, 2018
Merged
Conversation
b20723d to
4f2f8dd
Compare
ca4b925 to
59e15fb
Compare
Contributor
Author
|
Thanks for your feedback @kienstra . I made the corresponding changes. |
westonruter
reviewed
Apr 3, 2018
| esc_html__( 'The AMP plugin performs at its best when persistent object cache is enabled.', 'amp' ), | ||
| esc_url( 'https://codex.wordpress.org/Class_Reference/WP_Object_Cache#Persistent_Caching' ), | ||
| esc_html__( 'More details', 'amp' ), | ||
| esc_html__( 'Dismiss this notice.', 'amp' ) |
Member
There was a problem hiding this comment.
I think we should eliminate the dismissal because as soon as the page reload the notice comes right back.
Member
There was a problem hiding this comment.
@oscarssanchez once this change is made the PR will be good to merge.
Contributor
Author
|
Hi @westonruter, Thanks for your comments, I just did the changes. |
westonruter
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @westonruter,
Could you use this PR which addresses #960 ?
I was not sure where it was best to write the method in, so I opted to write it in class-amp-validation-utils but i'm open to your suggestions.
I'm also not sure if the output message would be good as it is now. I opted to include a link to https://codex.wordpress.org/Class_Reference/WP_Object_Cache#Persistent_Caching since users might not know what persistent object cache is and how to enable it.
Fixes #960.