Skip to content

Issue #868: Add Comment Unit Tests for PR #909#1049

Merged
westonruter merged 6 commits into0.7from
add/868-comments-unit-tests
Apr 3, 2018
Merged

Issue #868: Add Comment Unit Tests for PR #909#1049
westonruter merged 6 commits into0.7from
add/868-comments-unit-tests

Conversation

@kienstra
Copy link
Copy Markdown
Contributor

@kienstra kienstra commented Mar 30, 2018

Request For Review

Hi @westonruter,
No hurry here, as this is a holiday. But when you can, could you please review this PR for Issue #868?

It adds PHPUnit tests for #909. PR #1034 has the tests for AMP_Theme_Support.

Ryan Kienstra added 6 commits March 30, 2018 11:09
And test all of its methods.
@todo: tests for remaining methods in PR #909.
Add a test for process_comment_form().
@todo: continue with that,
and AMP_Comments_Sanitizer::sanitize().
Test more of the method,
including the 'on' value of the form elements.
Improve some of the method descriptions.
And move parent::setUp() to the bottom of setUp().
I deleted some empty lines,
and that moved some lines together.
Those lines need their = to be vertically-aligned.
Remove \ before WP_UnitTestCase.
This test isn't in a namespace,
so it isn't needed.
@kienstra kienstra requested a review from westonruter March 30, 2018 18:03
@kienstra kienstra changed the title [WIP] Issue #868: Add Comment Unit Tests for PR #909 Issue #868: Add Comment Unit Tests for PR #909 Mar 30, 2018
@westonruter westonruter merged commit 4848408 into 0.7 Apr 3, 2018
@westonruter westonruter deleted the add/868-comments-unit-tests branch April 3, 2018 06:57
@westonruter westonruter added this to the v0.7 milestone Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants