Skip to content

Avoid showing Stale Results when landing on Settings Screen from Onboarding Wizard #6692

@westonruter

Description

@westonruter

Feature Description

Currently as soon as the Onboarding Wizard completes and the user is taken to the Settings Screen, the first thing they will see is stale results in the Site Scan. This would be confusing to the user because they had just performed a Site Scan in the Onboarding Wizard. There are two reasons why the Site Scan results from the Wizard aren't showing on Settings Screen:

  1. The validated URLs are not being requested to be cached.
  2. The user may not have selected Standard mode.

For the first point: instead of validating URLs with amp-first, we can instead pass the desire to check URLs in Standard Mode by passing a parameter like amp_validate[force_standard_mode]=1. This amp_validate parameter is removed from the URL when it is stored in the Validated URL, so then such URLs should be returned when obtaining the Scannable URLs on the Settings Screen, if they had been requested to be cached in the onboarding wizard.

For the second point: When the user clicks "Close" to exit the Onboarding Wizard to go back to the Settings screen, there should be a query parameter included to indicate they had just completed the Wizard. When this parameter is present, if the Site Scan results are stale, a scan should be automatically initiated.

cf. #6683 (comment)

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

Metadata

Metadata

Assignees

Labels

ChangeloggedWhether the issue/PR has been added to release notes.EnhancementNew feature or improvement of an existing oneP0High prioritySite Scanning

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions