Skip to content

Validate only AMP-enabled pages in Site Scan  #6650

@delawski

Description

@delawski

Feature Description

A list of URLs being validated by the Site Scan feature should vary depending on the current state of the Template Mode or Supported Templates option.


As part of the Site Scan feature proposed in #4719 and implemented in #6610, a client-side AMP validation is performed on a set of URL.

The URLs are provided by the ScannableURLProvider via ScannableURLsRestController. They are meant to represent various types of pages so that the Site Scan gives best results.

The existing implementation of the ScannableURLProvider does not take the current Template Mode or Supported Template types into consideration when returning the URLs. For instance, even though in the Reader mode only the post and page templates are AMP-enabled, the provider returns other URLs like the homepage or archives.

Moreover, despite the fact that the SiteScanContextProvider proposed in #6610 will correctly invalidate the scan results whenever a Template Mode or Supported Template types change, it will still not refetch the scannable URLs from the REST endpoint in such a case.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    ChangeloggedWhether the issue/PR has been added to release notes.EnhancementNew feature or improvement of an existing oneP0High prioritySite Scanning

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions