-
Notifications
You must be signed in to change notification settings - Fork 382
Closed
Labels
Description
Feature description
We need to more efficiently walk over the generated spec data, in particular to be able to find tag spec by a spec name. This will allow fleshing out validation errors in the UI with the full context and provide the user with information on amp.dev for more details.
- Separate extension specs from tag specs. This eliminates having to look up extension specs from among tag specs.
- Add ability to get a specific spec by name for a given tag, and use in the style sanitizer.
- Add assertion that
link rel=stylesheet for fontsspec is present. - Include
extension_typein generated spec data in order to determine if an extension is acustom-templaterather thancustom-element. - Remove obsolete/unused
AMP_Rule_Spec::$additional_allowed_tags. - Eliminate duplicate copies of spec in memory (e.g.
$allowed_tags,$DEFAULT_ARGS['amp_allowed_tags'], and$args['amp_allowed_tags']).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
Reactions are currently unavailable