Skip to content

WordPress TV embeds in Classic Editor result in validation error #4130

@westonruter

Description

@westonruter

Bug Description

Adding a WordPress.tv video embed via Classic Editor block results in a validation error:

image

Post content is as follows:

Video:

https://wordpress.tv/2009/03/16/anatomy-of-a-wordpress-theme-exploring-the-files-behind-your-theme/

Was it good?

Interestingly, if the video is added an Embed block, then no validation error results.

This appears to be a bug with AMP_WordPress_TV_Embed_Handler. As opposed to using the render_block filter it should instead using the embed_oembed_html filter.

Expected Behaviour

Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Additional context

  • WordPress version:
  • Plugin version:
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode:
  • PHP version:
  • OS:
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingEmbedsQA passedHas passed QA and is done

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions