-
Notifications
You must be signed in to change notification settings - Fork 382
Closed
Labels
BugSomething isn't workingSomething isn't working
Milestone
Description
Looking at #2692, I realized that even contributors have access to the AMP settings page, even though you cannot actually change the settings.
There's a message saying:
You do not have permission to modify these settings. They are shown here for your reference. Please contact your administrator to make changes.
Screenshot:
There are a few problems I see on that page:
- The Experiences checkboxes are not readonly.
- There are links to AMP Validated URLs and AMP Validation Error Index.
- The user can access the AMP Validated URLs screen, but cannot perform any action.
- The user has no access to the AMP Validation Error Index screen.
- This settings page is totally irrelevant for contributors and basically any user who is not an admin.
Users on my site should not need to see this screen. They don't even know what AMP is, nor should they need to know.
Suggested changes:
- Make checkboxes readonly
- Prevent access to AMP Validated URLs screen for users without the necessary permission
- Hide "View current site compatibility results for standard and transitional modes" link if user lacks permission
- Prevent access to settings screen if user lacks permission
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugSomething isn't workingSomething isn't working
