-
Notifications
You must be signed in to change notification settings - Fork 382
Closed
Description
As a user, I expect AMP validation notices to appear on each block that has an AMP issue.
- AC1: Identify when and why the block level notices do not appear.
- AC2: Ensure block level validation notices appear on with the block after saving and when the editor is in a clean state.
What we want
An AMP validation error should display at the block level within the Gutenberg editor to provide the user with more information at a granular level.
This is the UI notice we want:
Noted problems
There are multiple contributing factors for this issue. Here is a list:
- Gutenberg update changed filter hook name from
blocks.BlockEdittoeditor.BlockEdit. - Gutenberg update changed the block
uidproperty fromidtoclientId. - Block uids go out-of-sync. Witnessed on page/editor load and intermittently.
- Duplicated blocks cause all block level notices to disappear.
- The warning notice remains after removing all affected blocks.
- Both the top level and block level notices remain when turning off AMP on a post, i.e. switching the AMP toggle to off.
Reactions are currently unavailable
