Do not preload hero images using srcset#828
Merged
sebastianbenz merged 2 commits intomasterfrom Jun 8, 2020
Merged
Conversation
westonruter
reviewed
Jun 8, 2020
| @@ -69,17 +69,9 @@ class PreloadHeroImage { | |||
| preload.attribs.media = heroImage.media; | |||
| } | |||
| if (heroImage.srcset) { | |||
Member
There was a problem hiding this comment.
I wonder if this should be configurable? Should there be a flag to force inclusion of images that have srcset?
Collaborator
Author
There was a problem hiding this comment.
That would cause double image downloads which is something I'd prefer to avoid.
Member
There was a problem hiding this comment.
But only on non-Chromium browsers. It's not needed now, but it would be useful in the near future to evaluate the performance impact for pages that use srcset.
Co-authored-by: Weston Ruter <westonruter@google.com>
1aa1942 to
3680e30
Compare
westonruter
approved these changes
Jun 8, 2020
Collaborator
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #823