Conversation
…to sortLinterOutput Synching with upstream
packages/linter/src/cli.ts
Outdated
| /^(googlebot_desktop|googlebot_mobile|chrome_desktop|chrome_mobile)$/i, | ||
| "googlebot_mobile" | ||
| ) | ||
| .option(`-n, --no-supress`, "supress passing tests in output") |
There was a problem hiding this comment.
The description seems to contradict the parameter name (supress vs no supress).
There was a problem hiding this comment.
whoops typo. I did change this but forgot to commit the edit. Will fix
packages/cli/lib/cmds/lint.js
Outdated
|
|
||
| function lint(args, logger) { | ||
| return cli(['dummy'].concat(args), logger, 'amp lint'); // "dummy" to simulate process.argv | ||
| return cli(['dummy'].concat(args).concat(['-n']), logger, 'amp lint'); // "dummy" to simulate process.argv |
There was a problem hiding this comment.
Am I right that this will by default supress the passing tests? How do I print the passing tests? Do I need to set -n=false? I'd find it to be more intuitive to name the attribute something like --show-passing which is disabled by default.
There was a problem hiding this comment.
-n will unsupress the passing tests since they are hidden by default. I had to add this flag here to pass the toolbox testing suite, as one of its checks is "has at least one passing test".
I can change the flag to -s, --show-passing
…to sortLinterOutput Synching with upstream
@sebastianbenz