Support media attribute for hero image preloading#805
Merged
sebastianbenz merged 3 commits intomasterfrom May 29, 2020
Merged
Conversation
patrickkettner
approved these changes
May 28, 2020
| } | ||
| if ( | ||
| node.tagName === 'script' && | ||
| hasAttribute(node, 'template') && |
Collaborator
There was a problem hiding this comment.
is there a reason to check for its existence? if it doesn't, the next line would just be against undefined, right?
seems like it could be terse-d up into
return node.tagName === 'template' || node.tageName === 'script' && node.attribs.template === 'amp-mustache'or even
return node.tagName === 'template' || node.attribs.template === 'amp-mustache'no worries either way
Collaborator
Author
There was a problem hiding this comment.
attribs might be undefined
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.