Merged
Conversation
This PR adds the experimental module/nomodule runtime loading support. ESM module loading support can be added via the `experimentEsm=true` parameter.
Collaborator
Author
|
FYI: @mdmower @patrickkettner |
Collaborator
Author
|
...and FYI @schlessera @westonruter - we should add this to the wp plugin once the validator supports mjs files. |
Member
|
Filed issue for PHP Optimizer: https://github.com/ampproject/amp-wp/issues/4607 |
patrickkettner
approved these changes
Apr 25, 2020
Collaborator
patrickkettner
left a comment
There was a problem hiding this comment.
LGTM, just one question for my own edification
kristoferbaxter
approved these changes
Apr 27, 2020
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
Looks great! Nice work.
Collaborator
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the experimental module/nomodule runtime loading support.
ESM module loading support can be added via the
experimentEsm=trueparameter.