optimizer: Add lts option to URL rewriter#691
Merged
sebastianbenz merged 2 commits intoampproject:masterfrom Apr 15, 2020
Merged
optimizer: Add lts option to URL rewriter#691sebastianbenz merged 2 commits intoampproject:masterfrom
sebastianbenz merged 2 commits intoampproject:masterfrom
Conversation
Support optimizing AMP pages to use long-term stable URLs: https://github.com/ampproject/amphtml/blob/master/contributing/lts-release.md Update CLI with support for all current rewrite URLs options. Note that lts option is incompatible with specifying a custom host or a specific runtime version in URL rewrites. An error will be thrown if these options are used together.
Contributor
Author
|
Not quite ready. Need to update |
Contributor
Author
|
Depends on #695 |
sebastianbenz
approved these changes
Apr 14, 2020
| } | ||
| // TODO: If ampUrlPrefix is a relative URL, this will fall back to | ||
| // fetching the latest runtime version and boilerplate CSS from | ||
| // cdn.ampproject.org. Is this our best option? |
Collaborator
There was a problem hiding this comment.
Another option would be to support passing v0.css via a parameter
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I left this fallback in place so that this PR doesn't affect handling of relative ampUrlPrefix. I think we're both on-board with using absolute URLs for ampUrlPrefix going forward, so this will disappear in a future PR. Can we keep this as-is just for the purposes of this PR?
Collaborator
There was a problem hiding this comment.
absolutely. thanks!
This was referenced Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ampproject/amphtml/blob/master/contributing/lts-release.md
Note that lts option is incompatible with specifying a specific runtime version in URL rewrites. An error will be thrown if these options are used together.
Depends on #695
Fixes #629