optimizer: Revert unsupported self-hosting modifications#600
Merged
sebastianbenz merged 2 commits intoampproject:masterfrom Feb 6, 2020
Merged
optimizer: Revert unsupported self-hosting modifications#600sebastianbenz merged 2 commits intoampproject:masterfrom
sebastianbenz merged 2 commits intoampproject:masterfrom
Conversation
…roject#518)" This reverts commit 81e525d.
sebastianbenz
approved these changes
Feb 6, 2020
Collaborator
sebastianbenz
left a comment
There was a problem hiding this comment.
I'm very happy about this change :-) Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither of these self-hosting features was adopted by AMPHTML; roll them back.
/rtv/{rtv}when version specifiedRevert rationale: Publishers are expected to match the path structure adopted by cdn.ampproject.org closely, including
/rtv/{rtv}subdirs.Revert rationale: Publishers are expected to host the entire runtime from the same host; mix and match components not allowed.