Fix: Empty <amp-experiment> blocks boilerplate removal#581
Merged
sebastianbenz merged 3 commits intomasterfrom Jan 24, 2020
Merged
Fix: Empty <amp-experiment> blocks boilerplate removal#581sebastianbenz merged 3 commits intomasterfrom
sebastianbenz merged 3 commits intomasterfrom
Conversation
Collaborator
Author
|
@schlessera PTAL |
schlessera
suggested changes
Jan 24, 2020
Collaborator
schlessera
left a comment
There was a problem hiding this comment.
The logic is inverted.
Also, two of the spec files need to be adapted as their tags are empty, which should not be enough for the scenario they test:
78c4c2c to
807c6c8
Compare
Collaborator
Author
|
Hah! Fooled myself there. Thanks for noticing. Should be fixed now. I've also added more tests and improved the test names. @schlessera PTAL |
Collaborator
|
LGTM! |
Collaborator
Author
|
Thanks for the review! |
This was referenced Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #578