Add crossorigin=anonymous to nomodule scripts the same as module ones#1194
Merged
sebastianbenz merged 1 commit intoampproject:mainfrom Apr 9, 2021
Conversation
Collaborator
|
I replicated the behaviour of the AMP cache here. Not sure what the original intention was to omit it for nomodule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing the output of the
RewriteAmpUrlstransformer, I noticed that thenomodulescripts lacked thecrossorigin=anonymousattribute like the themodulescripts did. This makes them consistent.Aside: It seems to be that there should also be a transformer config option for whether
crossorigin=anonymousshould be added in the first place. Sure it should be added by default, but for some use cases it is not good to add, namely when you are wanting to opt-in to beta/experimental channels via cookie (cf. ampproject/amp-wp#4600). Nevertheless, for this to be feasible the validator would need to makecrossorigin=anonymousnon-mandatory for themodulepreloadlink and all module scripts. I assume the cookie-based opt-in works for modules.