Make ES modules option consistent#1188
Merged
sebastianbenz merged 3 commits intoampproject:mainfrom Apr 1, 2021
Merged
Conversation
sebastianbenz
approved these changes
Apr 1, 2021
Collaborator
sebastianbenz
left a comment
There was a problem hiding this comment.
Good one! Thanks for making this more consistent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES modules were changed to be used by default in the following PR: #1140
This also seems to have changed the config setting from
experimentEsmtoesmModulesEnabled.However, the
experimentEsmoption was not replaced everywhere, and the class docblock of theRewriteAmpUrlstransformer even documented both.The config being set in some of the spec tests is still using
experimentEsm, even though that has no function anymore. The fact that the tests still pass is only due to the change of the default fromfalsetotrue.