Skip to content

Skip fonts with a data: URL source from fontPreloading check#1186

Merged
sebastianbenz merged 3 commits intoampproject:mainfrom
westonruter:patch-1
Mar 30, 2021
Merged

Skip fonts with a data: URL source from fontPreloading check#1186
sebastianbenz merged 3 commits intoampproject:mainfrom
westonruter:patch-1

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented Mar 30, 2021

Fixes #1185

@westonruter westonruter marked this pull request as ready for review March 30, 2021 18:04
sebastianbenz
sebastianbenz requested changes Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test here: https://github.com/ampproject/amp-toolbox/tree/main/packages/page-experience/test-data/checks/fontPreloading

You can then run npm run test:snapshot to generate a snapshot.

@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Mar 30, 2021

I added a test in e9159fb.

You can then run npm run test:snapshot to generate a snapshot.

Actually npm run test:optimizer:snapshot, right? In any case, it's not seeming to work for me. Even on main it's failing with a with a bunch of errors like:

image

I did do npm install. I'm on Node v14.16.0 (LTS).

@sebastianbenz
Copy link
Copy Markdown
Collaborator

sebastianbenz commented Mar 30, 2021

You need to run it inside the page-experience directory. Sorry for not mentioning that.

@westonruter
Copy link
Copy Markdown
Member Author

westonruter commented Mar 30, 2021

OK, I'm now in packages/page-experience and I ran npm install. However:

$ npm run test:snapshot

> @ampproject/toolbox-page-experience@2.8.0-canary.14 test:snapshot …/amp-toolbox/packages/page-experience
> PAGE_EXPERIENCE_SNAPSHOT=true jest

sh: jest: command not found

Shouldn't jest be added as a dependency?

@sebastianbenz sebastianbenz merged commit 3f09b1f into ampproject:main Mar 30, 2021
@westonruter westonruter deleted the patch-1 branch March 30, 2021 19:02
@sebastianbenz sebastianbenz mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fontPreloading check erroneously advises to preload a font which is a data: URL

2 participants

@westonruter @sebastianbenz