Merged
Conversation
eae166f to
2c09402
Compare
Collaborator
Author
|
Hm. Looks like tests are non-deterministic as they depend on browser output. |
lluerich
approved these changes
Mar 22, 2021
Collaborator
lluerich
left a comment
There was a problem hiding this comment.
Two little nits and as you already mentioned the the one test relies on browser output and thus fails.
| * | ||
| * @param {Object} pageData | ||
| */ | ||
| const earlyIframes = (pageData, result) => { |
Collaborator
There was a problem hiding this comment.
I guess this should be called heroImages or something more descriptive.
| result.warn({ | ||
| title: 'Improve LCP by optimizing hero images', | ||
| message: | ||
| 'Let AMP Caches and Optimizers optimize your hero images, but adding the `data-hero` attribute to images in your first viewport.', |
893d143 to
83352ae
Compare
Collaborator
Author
|
Thanks for the review! Fixed the nits. |
..and suggest using data-hero attribute
83352ae to
1376906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..and suggest using data-hero attribute