♻️ Refactor icon font detection#1153
Merged
sebastianbenz merged 5 commits intoampproject:mainfrom Mar 2, 2021
lluerich:refactor/icon-font-detection
Merged
♻️ Refactor icon font detection#1153sebastianbenz merged 5 commits intoampproject:mainfrom lluerich:refactor/icon-font-detection
sebastianbenz merged 5 commits intoampproject:mainfrom
lluerich:refactor/icon-font-detection
Conversation
Collaborator
lluerich
commented
Mar 2, 2021
- uses list of grouped parameters
- fixes postcss-8 deprecation warning
sebastianbenz
approved these changes
Mar 2, 2021
Collaborator
sebastianbenz
left a comment
There was a problem hiding this comment.
Can you add tests for the new logic?
added 2 commits
March 2, 2021 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.