Show blurredPlaceholders warning only when enabled#1151
Merged
sebastianbenz merged 1 commit intoampproject:mainfrom Mar 1, 2021
Merged
Show blurredPlaceholders warning only when enabled#1151sebastianbenz merged 1 commit intoampproject:mainfrom
sebastianbenz merged 1 commit intoampproject:mainfrom
Conversation
|
|
sebastianbenz
approved these changes
Mar 1, 2021
Collaborator
sebastianbenz
left a comment
There was a problem hiding this comment.
Good one! Thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hi there!
I found that the warning of blurredPlaceholders was shown even if blurredPlaceholders option was disabled.
https://github.com/ampproject/amp-toolbox/tree/main/packages/optimizer#blurry-image-placeholders
I don't think there is a need to show the waring when the option is disabled.
So, I change that the waring is shown only when the option is enabled.