Add extension scripts in logical order#1143
Merged
sebastianbenz merged 2 commits intoampproject:mainfrom Feb 22, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an extension is added by the
AutoExtensionsImporterin the current code, thereferenceNodeis never updated, so all extensions are inserted immediately after the viewport node.This causes the extensions to be written into the markup in the opposite order in which they are detected:
This seems illogical and might lead to bugs in case ordering would be import.
This PR changes the code so that the
referenceNodeis always moved forward when an extension is added, and therefore keeps the ordering of the extensions intact: