-
Notifications
You must be signed in to change notification settings - Fork 241
<title> seems to be mis-prioritised #583
Copy link
Copy link
Open
Description
In several of the ReorderHeadTransformer spec tests, there's a <title> tag that gets reordered as well.
My tests in PHP are currently failing on these, and I think they are mis-prioritised in the expected_output.html files in the spec test suite here.
As an example:
Line 12 in 2a81fc3
| <title>Title</title><style amp-custom></style><style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript></head> |
As far as I understand, this section would apply for the <title> tag:
* (10) <style amp-custom>
* (11) any other tags allowed in <head>
* (12) AMP boilerplate (first style amp-boilerplate, then noscript)
If I'm not mistaken, <title> would fall under (11) here, which would mean it should be between <style amp-custom> and the boilerplate. However, it seems it is in front of both of them.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels