Report parser error when encountering singleton brace expansion rule patterns#714
Merged
rcebulko merged 5 commits intoampproject:masterfrom Feb 21, 2020
Merged
Report parser error when encountering singleton brace expansion rule patterns#714rcebulko merged 5 commits intoampproject:masterfrom
rcebulko merged 5 commits intoampproject:masterfrom
Conversation
danielrozenberg
approved these changes
Feb 21, 2020
| // and has resulted in broken owners rules. | ||
| // Ex. `{a,b}.js` becomes /(a|b)\.js/ | ||
| // Ex. `{a}.js` becomes /\{a\}\.js/ | ||
| if (/\{[^,]+\}/.test(pattern)) { |
Member
There was a problem hiding this comment.
New edge-case introduced in this PR: what if the file actually includes { and } in its name? 😅
Contributor
Author
There was a problem hiding this comment.
Then it is wrong 😆
Contributor
Author
There was a problem hiding this comment.
But actually that should be disallowed and I'm comfortable with not supporting that at present lmao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimatch glob parsing library Owners Bot uses for parsing patterns performs brace-expansion, but only if the braces contain comma-separated patterns. This is not obvious behavior, and has resulted in broken owners rules (see ampproject/amphtml#26899).
Ex.
"{a,b}.js"becomes/(a|b)\.js/Ex.
"{a}.js"becomes/\{a\}\.js/This PR identifies rules where there is a single pattern specified within a brace-expansion and rejects the rule, reporting an error. This will block future PRs from submitting rules broken in this way.
/cc @Enriqe