bug: add more error handling for cursor allocation exception#285
Merged
bug: add more error handling for cursor allocation exception#285
Conversation
Contributor
|
Makes sense AJ, good investigation. I also thought about the uncaught RuntimeException. |
dantetam
approved these changes
Jun 21, 2021
haoliu-amp
approved these changes
Jun 21, 2021
Contributor
Author
|
@dantetam yeah, our discussion last week helped me realize this bug wasn't "why is sqlite throwing this exception", but "why is this exception not getting caught" |
Contributor
|
Glad I could help you complete the ticket @ajhorst . The exception handling was actually pretty tricky. Anyway, are you doing the release today? Instructions are on the Confluence pages. |
Contributor
Author
|
Sure, I can handle the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283
The underlying android exception CursorWindowAllocationException was not correctly getting converted to our own implementation of that exception because its message string was formatted differently. This led to an unhandled RuntimeException being thrown.
This PR also checks for the alternate formatting before converting the exception.