Skip to content

fix: do not fetch advertising Id if adid tracking is disabled#366

Merged
justin-fiedler merged 1 commit intomainfrom
AMP-76882-disable-adid-not-working
Jun 13, 2023
Merged

fix: do not fetch advertising Id if adid tracking is disabled#366
justin-fiedler merged 1 commit intomainfrom
AMP-76882-disable-adid-not-working

Conversation

@falconandy
Copy link
Contributor

Additional note: in Android-Kotlin default value for limitAdTrackingEnabled is true, in Amplitude-Android - false

Maybe if adid tracking is disabled limitAdTrackingEnabled should be null.

@justin-fiedler
Copy link
Contributor

LGTM. Thanks @falconandy!

@justin-fiedler justin-fiedler merged commit a1f8cc8 into main Jun 13, 2023
@justin-fiedler justin-fiedler deleted the AMP-76882-disable-adid-not-working branch June 13, 2023 16:47
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
## [2.39.5](v2.39.4...v2.39.5) (2023-06-13)

### Bug Fixes

* do not fetch advertising Id if adid tracking is disabled ([#366](#366)) ([a1f8cc8](a1f8cc8))
@github-actions
Copy link

🎉 This PR is included in version 2.39.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants