fix: move inForeground reads/writes to main thread#362
Merged
justin-fiedler merged 2 commits intomainfrom Jun 1, 2023
Merged
Conversation
…ion-logic-to-prevent-long-sessions
justin-fiedler
approved these changes
Jun 1, 2023
justin-fiedler
approved these changes
Jun 1, 2023
justin-fiedler
approved these changes
Jun 1, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
## [2.39.4](v2.39.3...v2.39.4) (2023-06-01) ### Bug Fixes * move inForeground reads/writes to main thread ([#362](#362)) ([15b4b35](15b4b35))
|
🎉 This PR is included in version 2.39.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inForeground reads/writes moved to main thread.
The session logic has some differences compared to Amplitude-iOS. I would re-write session logic to match Ampltude-Kotlin/Amplitude-Swift implementation.
For some reason I have a few issues with the Amplitude-Android project on my machine with latest Android Studio: unresolved identifiers in test files,
./gradlew buildfails with204 tests completed, 35 failed(but in Android Studio UI all tests are green).